Skip to content
Snippets Groups Projects
  • Eelco Dolstra's avatar
    bbe97dff
    Make the Store API more type-safe · bbe97dff
    Eelco Dolstra authored
    Most functions now take a StorePath argument rather than a Path (which
    is just an alias for std::string). The StorePath constructor ensures
    that the path is syntactically correct (i.e. it looks like
    <store-dir>/<base32-hash>-<name>). Similarly, functions like
    buildPaths() now take a StorePathWithOutputs, rather than abusing Path
    by adding a '!<outputs>' suffix.
    
    Note that the StorePath type is implemented in Rust. This involves
    some hackery to allow Rust values to be used directly in C++, via a
    helper type whose destructor calls the Rust type's drop()
    function. The main issue is the dynamic nature of C++ move semantics:
    after we have moved a Rust value, we should not call the drop function
    on the original value. So when we move a value, we set the original
    value to bitwise zero, and the destructor only calls drop() if the
    value is not bitwise zero. This should be sufficient for most types.
    
    Also lots of minor cleanups to the C++ API to make it more modern
    (e.g. using std::optional and std::string_view in some places).
    bbe97dff
    History
    Make the Store API more type-safe
    Eelco Dolstra authored
    Most functions now take a StorePath argument rather than a Path (which
    is just an alias for std::string). The StorePath constructor ensures
    that the path is syntactically correct (i.e. it looks like
    <store-dir>/<base32-hash>-<name>). Similarly, functions like
    buildPaths() now take a StorePathWithOutputs, rather than abusing Path
    by adding a '!<outputs>' suffix.
    
    Note that the StorePath type is implemented in Rust. This involves
    some hackery to allow Rust values to be used directly in C++, via a
    helper type whose destructor calls the Rust type's drop()
    function. The main issue is the dynamic nature of C++ move semantics:
    after we have moved a Rust value, we should not call the drop function
    on the original value. So when we move a value, we set the original
    value to bitwise zero, and the destructor only calls drop() if the
    value is not bitwise zero. This should be sufficient for most types.
    
    Also lots of minor cleanups to the C++ API to make it more modern
    (e.g. using std::optional and std::string_view in some places).