Skip to content
Snippets Groups Projects
  1. Mar 16, 2018
  2. Mar 15, 2018
  3. Mar 14, 2018
  4. Mar 13, 2018
  5. Mar 12, 2018
  6. Mar 09, 2018
    • Eelco Dolstra's avatar
      Fix double free in Store::queryPathInfo() · 24b73981
      Eelco Dolstra authored
      It was holding on to a Value* (i.e. a std::shared_ptr<ValidPathInfo>*)
      outside of the pathInfoCache lock, so the std::shared_ptr could be
      destroyed between the release of the lock and the decrement of the
      std::shared_ptr refcount. This can happen if more than
      'path-info-cache-size' paths are added in the meantime, *or* if
      clearPathInfoCache() is called. The hydra-queue-runner queue monitor
      thread periodically calls the later, so is likely to trigger a crash.
      
      Fixes https://github.com/NixOS/hydra/issues/542.
      24b73981
    • Eelco Dolstra's avatar
      Merge pull request #1959 from redfish64/master · dc83c8ee
      Eelco Dolstra authored
      Modified MakeBinOp to no longer produce its name using concatenation …
      dc83c8ee
    • Tim Engler's avatar
      Modified MakeBinOp to no longer produce its name using concatenation and "##". · 383afab9
      Tim Engler authored
      Doing so prevents emacs tags from working, as well as makes the code extremely
      confusing for a newbie.
      
      In the prior state, if someone wants to find the definition of "ExprApp" for
      example, a grep through the code reveals nothing. Since the definition could be
      hiding in numerous ".h" files, it's really difficult to find. This personally
      took me several hours to figure out.
      383afab9
  7. Mar 07, 2018
  8. Mar 06, 2018
  9. Mar 05, 2018
  10. Mar 03, 2018
  11. Mar 02, 2018
    • Shea Levy's avatar
    • Shea Levy's avatar
    • Eelco Dolstra's avatar
      Merge pull request #1932 from mfiano/patch-1 · 5c7a6d07
      Eelco Dolstra authored
      nix-channel grammar and punctuation
      5c7a6d07
    • Tuomas Tynkkynen's avatar
      libexpr: Recognize newline in more places in lexer · a0e38c16
      Tuomas Tynkkynen authored
      Flex's regexes have an annoying feature: the dot matches everything
      except a newline. This causes problems for expressions like:
      
      "${0}\
      "
      
      where the backslash-newline combination matches this rule instead of the
      intended one mentioned in the comment:
      
          <STRING>\$|\\|\$\\ {
                          /* This can only occur when we reach EOF, otherwise the above
                          (...|\$[^\{\"\\]|\\.|\$\\.)+ would have triggered.
                          This is technically invalid, but we leave the problem to the
                          parser who fails with exact location. */
                          return STR;
                      }
      However, the parser actually accepts the resulting token sequence
      ('"' DOLLAR_CURLY 0 '}' STR '"'), which is a problem because the lexer
      rule didn't assign anything to yylval. Ultimately this leads to a crash
      when dereferencing a NULL pointer in ExprConcatStrings::bindVars().
      
      The fix does change the syntax of the language in some corner cases
      but I think it's only turning previously invalid (or crashing) syntax
      to valid syntax. E.g.
      
      "a\
      b"
      
      and
      
      ''a''\
      b''
      
      were previously syntax errors but now both result in "a\nb".
      
      Found by afl-fuzz.
      a0e38c16
    • Eelco Dolstra's avatar
      Fix error message · 939cf4cc
      Eelco Dolstra authored
      939cf4cc
  12. Mar 01, 2018
  13. Feb 28, 2018
  14. Feb 27, 2018
Loading