Skip to content
Snippets Groups Projects
  • Sebastien Carlier's avatar
    6d8962e8
    Switch from archive libraries to partial linking · 6d8962e8
    Sebastien Carlier authored
    
    Before this commit, weak symbols were not overridden by non-weak symbols
    found in archive libraries when linking with recent versions of
    binutils.  As stated in the System V ABI, "the link editor does not
    extract archive members to resolve undefined weak symbols".
    
    This commit changes all Makefiles to use partial linking (ld -r) instead
    of creating library archives, which forces all symbols to participate in
    linking, allowing non-weak symbols to override weak symbols as intended.
    This approach is also used by Linux, from which the gmake function
    cmd_link_o_target (defined in config.mk and used in all Makefiles) is
    inspired.
    
    The name of each former library archive is preserved except for
    extensions which change from ".a" to ".o".  This commit updates
    references accordingly where needed, in particular in some linker
    scripts.
    
    This commit reveals board configurations that exclude some features but
    include source files that depend these disabled features in the build,
    resulting in undefined symbols.  Known such cases include:
    - disabling CMD_NET but not CMD_NFS;
    - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
    
    Signed-off-by: default avatarSebastien Carlier <sebastien.carlier@gmail.com>
    6d8962e8
    History
    Switch from archive libraries to partial linking
    Sebastien Carlier authored
    
    Before this commit, weak symbols were not overridden by non-weak symbols
    found in archive libraries when linking with recent versions of
    binutils.  As stated in the System V ABI, "the link editor does not
    extract archive members to resolve undefined weak symbols".
    
    This commit changes all Makefiles to use partial linking (ld -r) instead
    of creating library archives, which forces all symbols to participate in
    linking, allowing non-weak symbols to override weak symbols as intended.
    This approach is also used by Linux, from which the gmake function
    cmd_link_o_target (defined in config.mk and used in all Makefiles) is
    inspired.
    
    The name of each former library archive is preserved except for
    extensions which change from ".a" to ".o".  This commit updates
    references accordingly where needed, in particular in some linker
    scripts.
    
    This commit reveals board configurations that exclude some features but
    include source files that depend these disabled features in the build,
    resulting in undefined symbols.  Known such cases include:
    - disabling CMD_NET but not CMD_NFS;
    - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
    
    Signed-off-by: default avatarSebastien Carlier <sebastien.carlier@gmail.com>
Makefile 1.14 KiB
#
# (C) Copyright 2007 Semihalf
#
# See file CREDITS for list of people who contributed to this
# project.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundatio; either version 2 of
# the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
# MA 02111-1307 USA
#

include $(TOPDIR)/config.mk

LIB	= $(obj)libapi.o

COBJS-$(CONFIG_API) += api.o api_net.o api_storage.o api_platform-$(ARCH).o

COBJS	:= $(COBJS-y)
SRCS	:= $(COBJS:.o=.c)
OBJS	:= $(addprefix $(obj),$(COBJS))

$(LIB):	$(obj).depend $(OBJS)
	$(call cmd_link_o_target, $(OBJS))

# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend