Skip to content
Snippets Groups Projects
Commit 11b9a4d8 authored by Stephen Warren's avatar Stephen Warren Committed by Tom Rini
Browse files

sf: fix timebase data type in _wait_ready()


get_timer() returns an unsigned 64-bit value, but is currently assigned to
a signed 32-bit variable. Due to sign extension and data truncation, this
causes the timeout loop in spi_flash_cmd_wait_ready() to immediately (and
incorrectly) fire for about 50% of all time values, based on whether bit
31 is set. In sandbox at least, this causes the test to pass or fail based
on system uptime, as opposed to time since the U-Boot binary was started.

Fixes: 4efad20a ("sf: Update status reg check in spi_flash_cmd_wait_ready")
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
Reviewed-by: default avatarJagan Teki <jteki@openedev.com>
parent ef5ebe95
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment