Skip to content
Snippets Groups Projects
Commit 81630a3b authored by Philipp Tomsich's avatar Philipp Tomsich
Browse files

scripts: setlocalversion: safely extract variables from auto.conf using awk


Moving SPL_LDSCRIPT to Kconfig triggered an unfortunate attempt of
command substitution, as the sourced auto.conf may include $(ARCH)
which tries to execute a command 'ARCH'.
This showed up as a warning similar to the following:
  include/config/auto.conf: line 209: ARCH: command not found

This change does no longer attempt to source auto.conf, but rather
passes it through awk to retrieve the values for CONFIG_LOCALVERSION
and CONFIG_LOCALVERSION_AUTO.  This will also mitigate the risk of
unintended command substitution.

Signed-off-by: default avatarPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Reported-by: default avatarAndy Yan <andy.yan@rock-chips.com>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
Reviewed-by: default avatarKlaus Goger <klaus.goger@theobroma-systems.com>
Reviewed-by: default avatarJakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
parent 18d38d3a
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment