Skip to content
Snippets Groups Projects
Commit cb466c05 authored by Rajeshwari Shinde's avatar Rajeshwari Shinde Committed by Heiko Schocher
Browse files

I2C: S3C24X0: Bug fixes in i2c_transfer


This patch corrects the following issues

1) Write the correct M/T Stop value to I2CSTAT after i2c write.
   According to the spec, after finish the data transmission, we should
   write a M/T Stop (I2C_MODE_MT | I2C_TXRX_ENA) to I2CSTAT instead of
   a M/R Stop (I2C_MODE_MR | I2C_TXRX_ENA).
2) Not split the write to I2CSTAT into 2 steps in i2c read.
   According to the spec, we should write the combined M/R Start value to
   I2CSTAT after setting the slave address to I2CDS
3) Fix the mistake of making an equality check to an assignment.
   In the case of I2C write with the zero-length address, while tranfering the
   data, it should be an equality check (==) instead of an assignment (=).

Signed-off-by: default avatarTom Wai-Hong Tam <waihong@chromium.org>
Signed-off-by: default avatarRajeshwari Shinde <rajeshwari.s@samsung.com>
parent cecf3c00
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment