Skip to content
Snippets Groups Projects
Commit d9fb6a4c authored by Fabio Estevam's avatar Fabio Estevam Committed by Stefano Babic
Browse files

mxs_spi: Return proper timeout error


Instead of returning -1, it is preferred to return -ETIMEDOUT in case of timeouts.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Acked-by: default avatarMarek Vasut <marex@denx.de>
parent a8930033
No related merge requests found
...@@ -162,7 +162,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, ...@@ -162,7 +162,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
if (mx28_wait_mask_set(&ssp_regs->hw_ssp_ctrl0_reg, if (mx28_wait_mask_set(&ssp_regs->hw_ssp_ctrl0_reg,
SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) { SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
printf("MXS SPI: Timeout waiting for start\n"); printf("MXS SPI: Timeout waiting for start\n");
return -1; return -ETIMEDOUT;
} }
if (tx) if (tx)
...@@ -174,7 +174,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, ...@@ -174,7 +174,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_status_reg, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_status_reg,
SSP_STATUS_FIFO_EMPTY, MXS_SPI_MAX_TIMEOUT)) { SSP_STATUS_FIFO_EMPTY, MXS_SPI_MAX_TIMEOUT)) {
printf("MXS SPI: Timeout waiting for data\n"); printf("MXS SPI: Timeout waiting for data\n");
return -1; return -ETIMEDOUT;
} }
*rx = readl(&ssp_regs->hw_ssp_data); *rx = readl(&ssp_regs->hw_ssp_data);
...@@ -184,7 +184,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, ...@@ -184,7 +184,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_ctrl0_reg, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_ctrl0_reg,
SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) { SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
printf("MXS SPI: Timeout waiting for finish\n"); printf("MXS SPI: Timeout waiting for finish\n");
return -1; return -ETIMEDOUT;
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment