Skip to content
Snippets Groups Projects
  1. Jun 12, 2020
  2. Jun 09, 2020
    • Matthew Bauer's avatar
      Support empty hash in fetchers · 19aa892f
      Matthew Bauer authored
      fetchTarball, fetchTree, and fetchGit all have *optional* hash attrs.
      This means that we need to be careful with what we allow to avoid
      accidentally making these defaults. When ‘hash = ""’ we assume the
      empty hash is wanted.
      19aa892f
    • Matthew Bauer's avatar
      Allow empty hash in derivations · 762273f1
      Matthew Bauer authored
      follow up of https://github.com/NixOS/nix/pull/3544
      
      This allows hash="" so that it can be used for debugging purposes. For
      instance, this gives you an error message like:
      
        warning: found empty hash, assuming you wanted 'sha256:0000000000000000000000000000000000000000000000000000'
        hash mismatch in fixed-output derivation '/nix/store/asx6qw1r1xk6iak6y6jph4n58h4hdmbm-nix':
          wanted: sha256:0000000000000000000000000000000000000000000000000000
          got:    sha256:0fpfhipl9v1mfzw2ffmxiyyzqwlkvww22bh9wcy4qrfslb4jm429
      762273f1
  3. Jun 05, 2020
  4. Jun 04, 2020
  5. Jun 03, 2020
  6. Jun 02, 2020
  7. May 30, 2020
    • Tobias Pflug's avatar
      Add tests for lru-cache.hh · eca1ff7a
      Tobias Pflug authored
      eca1ff7a
    • Nikola Knezevic's avatar
      Ensure we restrict refspec interpretation while fetching · fb38459d
      Nikola Knezevic authored
      As `git fetch` may chose to interpret refspec to it's liking, ensure that we
      only pass refs that begin with `refs/` as is, otherwise, prepend them with
      `refs/heads`. Otherwise, branches named `heads/foo` (I know it's bad, but it's
      allowed), would be fetched as `foo`, instead of `heads/foo`.
      fb38459d
    • Nikola Knezevic's avatar
      Improve ref validity checking in fetchGit · 77007d4e
      Nikola Knezevic authored
      The previous regex was too strict and did not match what git was allowing. It
      could lead to `fetchGit` not accepting valid branch names, even though they
      exist in a repository (for example, branch names containing `/`, which are
      pretty standard, like `release/1.0` branches).
      
      The new regex defines what a branch name should **NOT** contain. It takes the
      definitions from `refs.c` in https://github.com/git/git and `git help
      check-ref-format` pages.
      
      This change also introduces a test for ref name validity checking, which
      compares the result from Nix with the result of `git check-ref-format --branch`.
      77007d4e
  8. May 29, 2020
    • John Ericson's avatar
      Remove addToStore variant as requested by `FIXME` · fac0c2d5
      John Ericson authored
      The idea is it's always more flexible to consumer a `Source` than a
      plain string, and it might even reduce memory consumption.
      
      I also looked at `addToStoreFromDump` with its `// FIXME: remove?`, but
      the worked needed for that is far more up for interpretation, so I
      punted for now.
      fac0c2d5
  9. May 28, 2020
  10. May 27, 2020
  11. May 26, 2020
  12. May 25, 2020
Loading