Skip to content
Snippets Groups Projects
  1. May 30, 2014
  2. May 29, 2014
  3. May 27, 2014
  4. May 26, 2014
  5. May 25, 2014
    • Ian Campbell's avatar
      net/designware: Make DMA burst length configurable and reduce by default · 49692c5f
      Ian Campbell authored
      
      The correct value for this setting can vary across SoCs and boards, so make it
      configurable.
      
      Also reduce the default value to 8, which is the same default as used in the
      Linux driver.
      
      Signed-off-by: default avatarIan Campbell <ijc@hellion.org.uk>
      Cc: Alexey Brodkin <abrodkin@synopsys.com>
      49692c5f
    • Ian Campbell's avatar
      net/designware: reorder struct dw_eth_dev to pack more efficiently. · 1857075a
      Ian Campbell authored
      
      On Thu, 2014-05-08 at 22:26 +0100, Ian Campbell wrote:
      > The {r,t}xbuffs fields also need to be aligned. Previously this was done
      > implicitly because they immediately followed the descriptor tables. Make this
      > explicit and also move to the head of the struct.
      
      Looks like I managed to not actually commit the move of the field to the
      head of the struct! v3.1 follows....
      
      Ian.
      
      8<------------
      
      >From 2937ba01841887317f6792709ed57cb86b5fc0cd Mon Sep 17 00:00:00 2001
      From: Ian Campbell <ijc@hellion.org.uk>
      Date: Thu, 1 May 2014 19:45:15 +0100
      Subject: [PATCH] net/designware: reorder struct dw_eth_dev to pack more
       efficiently.
      
      The {tx,rx}_mac_descrtable fields are aligned to ARCH_DMA_MINALIGN, which could
      be 256 or even larger. That means there is a potentially huge hole in the
      struct before those fields, so move them to the front where they are better
      packed.
      
      Moving them to the front also helps ensure that so long as dw_eth_dev is
      properly aligned (which it is since "net/designware: ensure device private data
      is DMA aligned.") the {tx,rx}_mac_descrtable will be too, or at least avoids
      having to worry too much about compiler specifics.
      
      The {r,t}xbuffs fields also need to be aligned. Previously this was done
      implicitly because they immediately followed the descriptor tables. Make this
      explicit and also move to the head of the struct.
      
      Signed-off-by: default avatarIan Campbell <ijc@hellion.org.uk>
      Cc: Alexey Brodkin <abrodkin@synopsys.com>
      Tested-by: default avatarSiarhei Siamashka <siarhei.siamashka@gmail.com>
      Reviewed-by: default avatarSiarhei Siamashka <siarhei.siamashka@gmail.com>
      1857075a
    • Ian Campbell's avatar
      net/designware: ensure cache invalidations are aligned to ARCH_DMA_MINALIGN · 964ea7c1
      Ian Campbell authored
      
      This is required at least on ARM.
      
      When sending instead of simply invalidating the entire descriptor, flush
      as little as possible while still respecting ARCH_DMA_MINALIGN, as
      requested by Alexey.
      
      Signed-off-by: default avatarIan Campbell <ijc@hellion.org.uk>
      Cc: Alexey Brodkin <abrodkin@synopsys.com>
      964ea7c1
Loading