Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Dec 15, 2019
  3. Dec 11, 2019
    • Michael Auchter's avatar
      i2c: i2c_cdns: fix write timeout on fifo boundary · 3104162a
      Michael Auchter authored 
      
This fixes an issue that would cause I2C writes to timeout when the
number of bytes is a multiple of the FIFO depth (i.e. 16 bytes).

Within the transfer loop, after writing the data register with a new
byte to transfer, if the transfer size equals the FIFO depth, the loop
pauses until the INTERRUPT_COMP bit asserts to indicate data has been
sent. This same check is performed after the loop as well to ensure data
has been transferred prior to returning.

In the case where the amount of data to be written is a multiple of the
FIFO depth, the transfer loop would wait for the INTERRUPT_COMP bit to
assert after writing the final byte, and then wait for this bit to
assert once more. However, since the transfer has finished at this
point, no new data has been written to the data register, and hence
INTERRUPT_COMP will never assert.

Fix this by only waiting for INTERRUPT_COMP in the transfer loop if
there's still data to be written.

Signed-off-by: default avatarMichael Auchter <michael.auchter@ni.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
      3104162a
    • Michael Auchter's avatar
      cros_ec: use uint instead of uint8_t for cmd param · b4f98b3b
      Michael Auchter authored 
      
Chromium EC commands can be up to 16-bits, so using a uint8_t here can
cause truncation. Update to use a uint instead.

It looks like this should likely have been done as a part of
9fea76f5, but this function was skipped
for some reason.

Signed-off-by: default avatarMichael Auchter <michael.auchter@ni.com>
Cc: Simon Glass <sjg@chromium.org>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
      b4f98b3b
  5. Dec 10, 2019
  7. Dec 09, 2019