- May 01, 2020
-
-
Eelco Dolstra authored
(cherry picked from commit bc5d4843)
-
Eelco Dolstra authored
-
Domen Kožar authored
Revamp README.md
-
Domen Kožar authored
-
Domen Kožar authored
Co-authored-by:
worldofpeace <worldofpeace@protonmail.ch>
-
Domen Kožar authored
Co-authored-by:
worldofpeace <worldofpeace@protonmail.ch>
-
- Apr 30, 2020
-
-
Tobias Pflug authored
-
Domen Kožar authored
-
Domen Kožar authored
-
Eelco Dolstra authored
This avoids inheriting the caller's shellHook, which can happen when running a dev-shell inside a dev-shell.
-
Eelco Dolstra authored
Tested against https://github.com/NixOS/nixpkgs/pull/72074. Fixes #3540.
-
Eelco Dolstra authored
-
Domen Kožar authored
Fix displaying error-position in `builtins.fetch{Tree,Tarball}`
-
- Apr 29, 2020
-
-
Maximilian Bosch authored
Without dereferencing this pointer, you'd get an error like this: ``` error: unsupported argument 'abc' to 'fetchTarball', at 0x13627e8 ```
-
Eelco Dolstra authored
Only call grantpt on MacOS systems
-
Antoine Eiche authored
The commit 3cc11255 adds a `grantpt` call on the builder pseudo terminal fd. This call is actually only required for MacOS, but it however requires a RW access to /dev/pts which is only RO bindmounted in the Bazel Linux sandbox. So, Nix can not be actually run in the Bazel Linux sandbox for unneeded reasons.
-
- Apr 28, 2020
-
-
Eelco Dolstra authored
Set GCROOT to store path to prevent garbage collection
-
Matthew Kenigsberg authored
-
Eelco Dolstra authored
-
Eelco Dolstra authored
Fix long paths permanently breaking GC
-
- Apr 27, 2020
-
-
Alyssa Ross authored
Suppose I have a path /nix/store/[hash]-[name]/a/a/a/a/a/[...]/a, long enough that everything after "/nix/store/" is longer than 4096 (MAX_PATH) bytes. Nix will happily allow such a path to be inserted into the store, because it doesn't look at all the nested structure. It just cares about the /nix/store/[hash]-[name] part. But, when the path is deleted, we encounter a problem. Nix will move the path to /nix/store/trash, but then when it's trying to recursively delete the trash directory, it will at some point try to unlink /nix/store/trash/[hash]-[name]/a/a/a/a/a/[...]/a. This will fail, because the path is too long. After this has failed, any store deletion operation will never work again, because Nix needs to delete the trash directory before recreating it to move new things to it. (I assume this is because otherwise a path being deleted could already exist in the trash, and then moving it would fail.) This means that if I can trick somebody into just fetching a tarball containing a path of the right length, they won't be able to delete store paths or garbage collect ever again, until the offending path is manually removed from /nix/store/trash. (And even fixing this manually is quite difficult if you don't understand the issue, because the absolute path that Nix says it failed to remove is also too long for rm(1).) This patch fixes the issue by making Nix's recursive delete operation use unlinkat(2). This function takes a relative path and a directory file descriptor. We ensure that the relative path is always just the name of the directory entry, and therefore its length will never exceed 255 bytes. This means that it will never even come close to AX_PATH, and Nix will therefore be able to handle removing arbitrarily deep directory hierachies. Since the directory file descriptor is used for recursion after being used in readDirectory, I made a variant of readDirectory that takes an already open directory stream, to avoid the directory being opened multiple times. As we have seen from this issue, the less we have to interact with paths, the better, and so it's good to reuse file descriptors where possible. I left _deletePath as succeeding even if the parent directory doesn't exist, even though that feels wrong to me, because without that early return, the linux-sandbox test failed. Reported-by:
Alyssa Ross <hi@alyssa.is> Thanks-to: Puck Meerburg <puck@puckipedia.com> Tested-by:
Puck Meerburg <puck@puckipedia.com> Reviewed-by:
Puck Meerburg <puck@puckipedia.com>
-
Matthew Kenigsberg authored
-
Matthew Kenigsberg authored
-
- Apr 25, 2020
-
-
Linus Heckemann authored
Reduces the number of store queries it performs. Also prints a warning if any of the selectors did not match any installed derivations. UX Caveats: - Will print a warning that nothing matched if a previous selector already removed the path - Will not do anything if no selectors were provided (no change from before). Fixes #3531
-
- Apr 22, 2020
-
-
Eelco Dolstra authored
-
Eelco Dolstra authored
-
Eelco Dolstra authored
(cherry picked from commit c7af247b)
-
Eelco Dolstra authored
Replace select() with poll()
-
- Apr 21, 2020
-
-
Dustin DeWeese authored
-
- Apr 18, 2020
-
-
Domen Kožar authored
pass Pos to forceValue to improve infinite recursion error
-
- Apr 16, 2020
-
-
Ben Burdette authored
-
Eelco Dolstra authored
(cherry picked from commit 8f418473)
-
Eelco Dolstra authored
Usually this just writes to stdout, but for ProgressBar, we need to clear the current line, write the line to stdout, and then redraw the progress bar. (cherry picked from commit 696c0260)
-
Eelco Dolstra authored
-
Ben Burdette authored
-
Eelco Dolstra authored
More #3377.
-
Eelco Dolstra authored
We want to *trace* the 'Value *' arrays, not garbage-collect them! Otherwise the vectors/maps can end up pointing to nowhere. Fixes #3377. Closes #3384.
-
Eelco Dolstra authored
-